Add HasValue and IsEmpty properties

[cieciurm]

Hi @mcintyre321,

Thanks for your awesome work on ValueOf.

I was trying it out and everything is great, except for the fact that I was missing a way to check if the identifier was actually initialized with a value. So I thought adding two properties:

• HasValue - which checks if the Value was set
• IsEmpty - which is a negation of HasValue

could be a small tweak for this small library.

Please let me know if it works for you. If there is something I can adjust, just let me know.

Thanks,
Mateusz

BTW. I also took the liberty and updated package versions for the Test project.

[mcintyre321]

I'm not sure what circumstances it could not be set?

…

On Fri, 24 Mar 2023, 17:15 Mateusz, ***@***.***> wrote: Hi @mcintyre321 <https://github.com/mcintyre321>, Thanks for your awesome work on ValueOf. I was trying it out and everything is great, except for the fact that I was missing a way to check if the identifier was actually initialized with a value. So I thought adding two properties: - HasValue - which checks if the Value was set - IsEmpty - which is a negation of HasValue could be a small tweak for this small library. Please let me know if it works for you. If there is something I can adjust, just let me know. Thanks, Mateusz BTW. I also took the liberty and updated package versions for the Test project. ------------------------------ You can view, comment on, or merge this pull request online at: #37 Commit Summary - b4c4958 <b4c4958> Add HasValue and IsEmpty properties File Changes (3 files <https://github.com/mcintyre321/ValueOf/pull/37/files>) - *A* ValueOf.Tests/HasValue.cs <https://github.com/mcintyre321/ValueOf/pull/37/files#diff-1dab2d9a854f5a60cbab9ee8046e269be51dd19dc2bcc713ec98ead4a86e0630> (71) - *M* ValueOf.Tests/ValueOf.Tests.csproj <https://github.com/mcintyre321/ValueOf/pull/37/files#diff-78b79a46bf976d09eea9d8183285608d6e834e0567b0fa21befd315d4480c758> (6) - *M* ValueOf/ValueOf.cs <https://github.com/mcintyre321/ValueOf/pull/37/files#diff-009de4af0fa7a432848cafd361ab40f9449b7e36e7917c6346740bafe34aefee> (4) Patch Links: - https://github.com/mcintyre321/ValueOf/pull/37.patch - https://github.com/mcintyre321/ValueOf/pull/37.diff — Reply to this email directly, view it on GitHub <#37>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACDJ6RTUHE6NSLPSERSC23W5XJCJANCNFSM6AAAAAAWG2MPSU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[cieciurm]

Currently, if you instantiate a new object deriving from ValueOf it doesn't have a Value set.

Example:

public class StringId : ValueOf<string, StringId> { }

var id = new StringId();

The Value would be equal to the default value of string, so null.

When I was trying out the library for the first time, that's how I created an instance of my identifier. I didn't notice that there was a .From method.

So, I think that having those properties could be helpful in other parts of codebase to determine whether the identifier has been initialized from a value, or is it being created without specifying it.