Skip to content

Revert "Implicit operator removed" #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcintyre321 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert "Implicit operator removed" #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ValueOf.Tests/Equals.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public void CaseInsensitiveEquals()
Assert.AreEqual(clientRef1, clientRef2);
Assert.AreEqual(clientRef1.GetHashCode(), clientRef2.GetHashCode());
Assert.IsTrue(clientRef1 == clientRef2);
Assert.IsTrue(clientRef1.Value == "ASDF12345");
Assert.IsTrue(clientRef1 == "ASDF12345");

CaseInsensitiveClientRef clientRef3 = CaseInsensitiveClientRef.From("QWER98765");
Assert.AreNotEqual(clientRef1, clientRef3);
Expand Down
5 changes: 4 additions & 1 deletion ValueOf/ValueOf.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,10 @@ public override int GetHashCode()
return !(a == b);
}

// Implicit operator removed. See issue #14.
public static implicit operator TValue(ValueOf<TValue, TThis> a)
{
return a.Value;
}

public override string ToString()
{
Expand Down