Skip to content

Implement suggestions #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mccoyp merged 2 commits into from
Jan 9, 2026
Merged

Implement suggestions #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2550497
Implement suggestions
mccoyp Jan 8, 2026
7088472
Merge branch 'kv-repro' into port-fix
mccoyp Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...e-keyvault-administration/azure/keyvault/administration/_internal/http_challenge_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,9 @@ def remove_challenge_for_url(url: str) -> None:
if not url:
raise ValueError("URL cannot be empty")

parsed = parse.urlparse(url)

key = _get_cache_key(url)
with _lock:
del _cache[parsed.netloc.lower()]
del _cache[key.lower()]


def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None:
Expand All @@ -82,8 +81,9 @@ def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None:
if src_url.netloc.lower() != challenge.source_authority.lower():
raise ValueError("Source URL and Challenge URL do not match")

key = _get_cache_key(url)
with _lock:
_cache[src_url.netloc.lower()] = challenge
_cache[key.lower()] = challenge


def clear() -> None:
Expand Down
8 changes: 4 additions & 4 deletions ...t/azure-keyvault-certificates/azure/keyvault/certificates/_shared/http_challenge_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,9 @@ def remove_challenge_for_url(url: str) -> None:
if not url:
raise ValueError("URL cannot be empty")

parsed = parse.urlparse(url)

key = _get_cache_key(url)
with _lock:
del _cache[parsed.netloc.lower()]
del _cache[key.lower()]


def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None:
Expand All @@ -82,8 +81,9 @@ def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None:
if src_url.netloc.lower() != challenge.source_authority.lower():
raise ValueError("Source URL and Challenge URL do not match")

key = _get_cache_key(url)
with _lock:
_cache[src_url.netloc.lower()] = challenge
_cache[key.lower()] = challenge


def clear() -> None:
Expand Down
8 changes: 4 additions & 4 deletions sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/http_challenge_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,9 @@ def remove_challenge_for_url(url: str) -> None:
if not url:
raise ValueError("URL cannot be empty")

parsed = parse.urlparse(url)

key = _get_cache_key(url)
with _lock:
del _cache[parsed.netloc.lower()]
del _cache[key.lower()]


def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None:
Expand All @@ -82,8 +81,9 @@ def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None:
if src_url.netloc.lower() != challenge.source_authority.lower():
raise ValueError("Source URL and Challenge URL do not match")

key = _get_cache_key(url)
with _lock:
_cache[src_url.netloc.lower()] = challenge
_cache[key.lower()] = challenge


def clear() -> None:
Expand Down
8 changes: 4 additions & 4 deletions sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/http_challenge_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,9 @@ def remove_challenge_for_url(url: str) -> None:
if not url:
raise ValueError("URL cannot be empty")

parsed = parse.urlparse(url)

key = _get_cache_key(url)
with _lock:
del _cache[parsed.netloc.lower()]
del _cache[key.lower()]


def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None:
Expand All @@ -82,8 +81,9 @@ def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None:
if src_url.netloc.lower() != challenge.source_authority.lower():
raise ValueError("Source URL and Challenge URL do not match")

key = _get_cache_key(url)
with _lock:
_cache[src_url.netloc.lower()] = challenge
_cache[key.lower()] = challenge


def clear() -> None:
Expand Down
9 changes: 4 additions & 5 deletions ...e-keyvault-securitydomain/azure/keyvault/securitydomain/_internal/http_challenge_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,9 @@ def remove_challenge_for_url(url: str) -> None:
if not url:
raise ValueError("URL cannot be empty")

parsed = parse.urlparse(url)

key = _get_cache_key(url)
with _lock:
del _cache[parsed.netloc.lower()]

del _cache[key.lower()]

def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None:
"""Caches the challenge for the specified URL.
Expand All @@ -82,8 +80,9 @@ def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None:
if src_url.netloc.lower() != challenge.source_authority.lower():
raise ValueError("Source URL and Challenge URL do not match")

key = _get_cache_key(url)
with _lock:
_cache[src_url.netloc.lower()] = challenge
_cache[key.lower()] = challenge


def clear() -> None:
Expand Down