This repository was archived by the owner on Jan 28, 2020. It is now read-only.
Open
Conversation
This file gets loaded after config.js and has all the default values, which makes it impossible to override node['statsd']['graphite_host']. I ran into this on Ubuntu 14.04, but if it's happening elsewhere you might want to put the deletion in the default recipe.
mburns
suggested changes
May 9, 2018
Owner
mburns
left a comment
mburns
left a comment
There was a problem hiding this comment.
1 small request, otherwise looks good.
| # We do our config in /etc/statsd/config.js, this isn't needed. | ||
| file '/etc/statsd/localConfig.js' do | ||
| action :delete | ||
| notifies :restart, "service[statsd]" |
|
@coreyappleby any chance you can update the PR so we can get it merged by @mburns? Thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file gets loaded after config.js and has all the default values, which makes it impossible to override node['statsd']['graphite_host'].
I ran into this on Ubuntu 14.04, but if it's happening elsewhere you might want to put the deletion in the default recipe.