feat(SF2.0/UpcomingDepartures): show service ended state #2892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecristen
changed the title
joshlarson
requested changes
Jan 18, 2026
Contributor
joshlarson
left a comment
joshlarson
left a comment
There was a problem hiding this comment.
I like that the backend does this, and I'm pretty sure the fact that it short-circuits before rejecting :hidden departures means that this will Just Work™ for subway as well.
There's one test that's generating a warning. I can approve once that's cleared up.
Co-authored-by: Josh Larson <jlarson@mbta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: [SF/UD] All Modes: "Service ended" message after last vehicle of the day
Implementation
At the point of converting predicted schedules into upcoming departures, once we remove past schedules we're left with future ones. And if there are no future ones... we can conclude that service has ended.
Screenshots
How to test
Go to a route+stop at which has ended, such as (likely) the 171.