Skip to content

Adminuser#14

Open
aduprat wants to merge 5 commits intombaechler:masterfrom
aduprat:ADMINUSER
Open

Adminuser#14
aduprat wants to merge 5 commits intombaechler:masterfrom
aduprat:ADMINUSER

Conversation

@aduprat
Copy link
Copy Markdown
Collaborator

@aduprat aduprat commented Dec 12, 2014

No description provided.

@buildhive
Copy link
Copy Markdown

buildhive commented Dec 12, 2014

mbaechler » Greenmail #17 SUCCESS
This pull request looks good
(what's this?)

@buildhive
Copy link
Copy Markdown

buildhive commented Dec 14, 2014

mbaechler » Greenmail #18 SUCCESS
This pull request looks good
(what's this?)

@buildhive
Copy link
Copy Markdown

buildhive commented Dec 17, 2014

mbaechler » Greenmail #19 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@buildhive
Copy link
Copy Markdown

buildhive commented Dec 17, 2014

mbaechler » Greenmail #20 SUCCESS
This pull request looks good
(what's this?)

thomas-hilaire
thomas-hilaire reviewed Jan 5, 2015
View reviewed changes
Comment thread src/main/java/com/icegreen/greenmail/imap/commands/CreateCommand.java
Copy link
Copy Markdown

@thomas-hilaire thomas-hilaire Jan 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you not restore this line ?

Copy link
Copy Markdown
Collaborator Author

@aduprat aduprat Jan 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, i can't, because of the extra Cyrus parameter (partition).
The goal of this commit is to make the IMAP CREATE command compatible with Cyrus.

Copy link
Copy Markdown

@thomas-hilaire thomas-hilaire Jan 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks, it just looks weird to have this line commented.
Don't you prefer to either remove it at all or tell in a comment why you did that ?

@Lewik
Copy link
Copy Markdown

Lewik commented Feb 8, 2017 •
edited
Loading

Will maintainers merge this pr? (Out team very needs admin user)
Plus we need commands to configure admin users from command line.
I can repeat admin part code into new pr.

@Lewik Lewik mentioned this pull request Feb 8, 2017
Closed
@Lewik Lewik mentioned this pull request Feb 16, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aduprat @buildhive @Lewik @thomas-hilaire