Skip to content

Fix PARTIAL audit items in template command files #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maystudios merged 1 commit into from
Mar 25, 2026
Merged

Fix PARTIAL audit items in template command files #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions templates/commands/maxsim/debug.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ GitHub is the sole source of truth. Check for open Issues labeled `debug` to det
</context>

<process>
Plan Mode: Use EnterPlanMode when presenting symptom analysis and proposed diagnosis. Call ExitPlanMode before spawning the executor Agent for the fix.

Follow @.claude/maxsim/workflows/debug.md end-to-end. Invoke the `systematic-debugging` skill at step 3 to drive the reproduce-hypothesize-isolate-verify-fix cycle.

1. Check GitHub for open Issues labeled `debug` (active sessions)
Expand Down
2 changes: 1 addition & 1 deletion templates/commands/maxsim/go.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Follow @.claude/maxsim/workflows/go.md end-to-end.

1. Read GitHub Project Board state via `gh` CLI
2. Detect what's next using the priority list above
3. Enter Plan Mode — show detection reasoning and proposed action
3. Enter Plan Mode via EnterPlanMode — show detection reasoning and proposed action
4. Wait for user approval (Ctrl+C cancels)
5. Execute approved action by spawning the appropriate Agent
6. Report the result — print a completion summary or surface the error with a recovery suggestion
Expand Down
4 changes: 3 additions & 1 deletion templates/commands/maxsim/init.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,13 @@ GitHub is the sole source of truth. Init creates GitHub Milestones and Issues
</context>

<process>
Plan Mode: Call EnterPlanMode before presenting setup proposals to the user. Call ExitPlanMode after user approves.

Follow @.claude/maxsim/workflows/init.md end-to-end.
Comment on lines +22 to 24
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Plan Mode guidance here doesn’t match the referenced init workflows: init-existing.md/new-project.md require calling EnterPlanMode immediately after prerequisites and keeping scanning + GitHub setup within Plan Mode, exiting only after the user approves the complete init plan. Update this note to align with the workflow so the command template doesn’t instruct a different Plan Mode lifecycle.

Suggested change
Plan Mode: Call EnterPlanMode before presenting setup proposals to the user. Call ExitPlanMode after user approves.
Follow @.claude/maxsim/workflows/init.md end-to-end.
Plan Mode: After completing prerequisites, immediately call EnterPlanMode before starting repo scanning or proposing any setup. Keep scanning, user interview, GitHub setup, CLAUDE.md drafting, and roadmap proposals within Plan Mode. Call ExitPlanMode only after the user reviews and approves the complete init plan.
Follow @.claude/maxsim/workflows/init-existing.md and @.claude/maxsim/workflows/new-project.md (via @.claude/maxsim/workflows/init.md) end-to-end.

Copilot uses AI. Check for mistakes.

1. Scan repo in parallel — spawn Research agents to analyze architecture, frameworks, CI/CD, tests, dependencies, and documentation
2. Interview user: project name, description, goals, tech stack, conventions, testing strategy, deployment, acceptance criteria, no-gos, risks
3. GitHub Setup — ensure standard labels, create Project Board (Kanban), create Milestone, offer repo creation if needed
3. GitHub Setup — ensure standard labels (6 labels in 2 namespaces: type: and maxsim:), create Project Board (Kanban), create Milestone, offer repo creation if needed
4. Write CLAUDE.md with project context and MaxsimCLI config
5. Optionally generate Roadmap as GitHub Issues (phases)
6. Confirm setup and suggest `/maxsim:go` as next step
Expand Down
2 changes: 2 additions & 0 deletions templates/commands/maxsim/plan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ Re-entry: If phase is already planned, show status and offer options (view, re-p
</context>

<process>
Plan Mode: This command uses EnterPlanMode during the Discussion and Planning stages. Call ExitPlanMode before executing the approved plan.
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says EnterPlanMode is used during Discussion and Planning stages only, but the /maxsim:plan orchestrator workflow calls EnterPlanMode before any research or planning steps (i.e., it spans Discussion + Research + Planning). Please adjust this note to reflect the actual Plan Mode lifecycle used by templates/workflows/plan.md.

Suggested change
Plan Mode: This command uses EnterPlanMode during the Discussion and Planning stages. Call ExitPlanMode before executing the approved plan.
Plan Mode: This command enters Plan Mode before the Discussion stage and keeps it active through Discussion, Research, and Planning. Call ExitPlanMode before executing the approved plan.

Copilot uses AI. Check for mistakes.

Follow @.claude/maxsim/workflows/plan.md end-to-end.

1. Detect current stage from GitHub Issue labels on the phase Issue
Expand Down
2 changes: 1 addition & 1 deletion templates/commands/maxsim/security.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: maxsim:security
description: Security audit — STRIDE + OWASP Top 10 + red-team analysis (read-only)
argument-hint: "[scope]"
allowed-tools: [Read, Bash, Grep, Glob, WebSearch, WebFetch]
allowed-tools: [Read, Bash, Grep, Glob, Agent, WebSearch, WebFetch]
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowed-tools now includes Agent, but the command explicitly claims it is READ-ONLY and that tools are restricted to read-only operations. Because Agent can spawn agents like executor (which has Write/Edit), this undermines the read-only guarantee; either remove Agent here or explicitly constrain any Agent usage to read-only agents (e.g., researcher) and state that write-capable agents must not be spawned from this command.

Copilot uses AI. Check for mistakes.
---

<objective>
Expand Down
Loading