Skip to content

Fix repl and other misc code, including test #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
michalz-zoom wants to merge 6 commits into
base: iced2
Choose a base branch
from
Open

Fix repl and other misc code, including test #211

michalz-zoom wants to merge 6 commits into from

Conversation

@michalz-zoom
Copy link

@michalz-zoom michalz-zoom commented Dec 16, 2025 •
edited
Loading

  • At some point Node.js repl.rli was deprecated. Properties of 'rli' were already present in 'repl' REPLServer object, so this is a simple change.
  • Fix Buffer constructor calls which are deprecated.
  • Fix other test files, again, mostly Node libraries changing things around (changes in vm.Script, fs.unlink, assert.throws etc.)
  • In Cakefile, be more verbose where the global functions come from ('assert' module - ok, fail etc.), also add a way to run single (or multiple) test files instead of full test suite.

@michalz-zoom
Cakefile housekeeping, add test filtering
4d9e30e
@michalz-zoom
Fix repl
607d149 
At some point Node.js repl.rli was deprecated. Properties of 'rli'
were already present in 'repl' REPLServer object, so this is a simple
change.
@michalz-zoom
Fix eval
20dea39
@michalz-zoom
Fix test/exception_handling.coffee
716a8d6 
Node.js 'assert' module complains if we try to use assert.throws to
check an exception that is literally Error('error') has a message
'error', saying that it's ambiguous.
@michalz-zoom
Fix test/syntax-error.coffee
1740178 
We were calling fs.unlink without providing callback, so this test was
failing to clean up its temporary file.
@michalz-zoom
Fix test/repl.coffee
d015fcb
@michalz-zoom michalz-zoom changed the title Fix repl Fix repl and other misc code, including test Dec 17, 2025
@michalz-zoom
Copy link
Author

michalz-zoom commented Dec 17, 2025

@maxtaco please take a look :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@michalz-zoom