Skip to content

Refactor CSS variable names for consistency#6128

Draft
kyrapieterse wants to merge 47 commits intomasterfrom
ename-varbles
Draft

Refactor CSS variable names for consistency#6128
kyrapieterse wants to merge 47 commits intomasterfrom
ename-varbles

Conversation

@kyrapieterse
Copy link
Copy Markdown
Contributor

@kyrapieterse kyrapieterse commented Dec 20, 2025

An attempt at fixing the speed

Replaces long-form CSS custom property names (e.g., --maxi-primary-color) with shorter, standardized abbreviations (e.g., --mpc) across admin, starter sites, and library styles. Updates all relevant SCSS, CSS, and React icon usage to reference the new variable names, improving maintainability and consistency throughout the codebase.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 20, 2025

Important

Review skipped

Too many files!

130 files out of 280 files are above the max files limit of 150.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ename-varbles

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 6 to 7
</defs>
e xlinkHref="#scale__a" /> inkHref="#scale__b" transform="translate(.04 -.023) scale(.99998)" /> ref="#scale__c" transform="translate(0 .009) scale(.99998)" />
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore missing nodes in scale SVG

The scale.svg markup is corrupted: instead of <use> elements referencing scale__a/b/c, line 7 now contains the literal text e xlinkHref... with no valid tags. This makes the “scale” setting icon render nothing wherever the raw SVG is used (e.g., in the settings panel or icon picker). The previous version had three <use> elements here; they need to be reinstated so the icon draws correctly.

Useful? React with 👍 / 👎.

@kyrapieterse
Copy link
Copy Markdown
Contributor Author

kyrapieterse commented Dec 24, 2025

Notes for @elzadj

I was unable to rename maxi-blocks--active, maxi-container-block maybe there is a way you can. extremely heavy these 2

skipped items like maxi-hover-effect, maxi-background-displayer, maxi-slider-block, and maxi-image-block. Reason: These classes are saved in the database (static HTML). Renaming them now would break the styling of all existing content on your site.

Comment thread src/extensions/maxi-block/maxiBlockComponent.js Fixed
Comment thread src/extensions/maxi-block/maxiBlockComponent.js Fixed
@kyrapieterse kyrapieterse marked this pull request as draft January 5, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant