panic on empty word list#150
Merged
max-niederman merged 1 commit intomax-niederman:mainfrom Mar 12, 2026
Merged
Conversation
SimonRenblad
force-pushed
the
fix_empty_word_list
branch
2 times, most recently
from
9e8a437 to
96e8c94
Compare
Collaborator
|
Looks good @max-niederman Maybe one day we could have retry logic, like open a language picker to toggle to? |
max-niederman
approved these changes
Mar 12, 2026
Owner
max-niederman
left a comment
max-niederman
left a comment
There was a problem hiding this comment.
This is a good change, though in the future we may want to have proper error handling rather than panics for everything.
max-niederman
force-pushed
the
fix_empty_word_list
branch
from
96e8c94 to
c83709d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #149