LLDP: enable configuration on the fly #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`make_lldp_manager` is implemented as a lambda and receives a list of host interfaces at creation of the handler. If i.e. the IP address of an interface changes the lldp-manager has to destroyed and recreated. By re-reading the `host_interfaces` from the `model.settings` this can be avoided and `configure_interfaces` can be called instead.
maweit
pushed a commit
that referenced
this pull request
Oct 31, 2025
Added /rolePaths/{rolePath}/properties endpoint
Co-authored-by: Simon Lo <simon.lo@sony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_lldp_manageris implemented as a lambda and receives a list of host interfaces at creation of the handler. If i.e. the IP address of an interface changes the lldp-manager has to destroyed and recreated. By re-reading thehost_interfacesfrom themodel.settingsthis can be avoided andconfigure_interfacescan be called instead.