Skip to content

docs: Clarify relative date filter behavior across languages#700

Merged
adiati98 merged 3 commits into
mautic:7.1from
Promptless:promptless/relative-date-filters-language-support
Apr 23, 2026
Merged

docs: Clarify relative date filter behavior across languages#700
adiati98 merged 3 commits into
mautic:7.1from
Promptless:promptless/relative-date-filters-language-support

Conversation

@promptless-for-oss
Copy link
Copy Markdown

Open this suggestion in Promptless to view citations and reasoning process

Clarifies that relative date values in Segment filters work correctly regardless of Mautic's language setting, based on the bug fix in PR #15791.

Changes

segments/manage_segments.rst

  • Updated Date options section: Simplified the explanation of translatable date formulas to clarify that Mautic displays them in the current language setting
  • New tip: Added a tip explaining that relative date values like today, tomorrow, and this week work correctly regardless of language setting, and switching languages doesn't affect Segment evaluation

Context

PR #15791 fixed a bug where relative date values in Segment filters would break when users switched languages. Previously, values like 'today' stored in German ('heute') would become '1970-01-01 00:00' when switching to English. The fix ensures relative dates are stored consistently and translated at the UI level, making Segment evaluation language-independent.


Tip: Use labels in the Promptless dashboard to categorize suggestions by release or team 🏷️

@promptless-for-oss promptless-for-oss requested a review from a team as a code owner April 22, 2026 10:09
@promptless-for-oss promptless-for-oss requested review from adiati98 and favour-chibueze and removed request for a team April 22, 2026 10:09
Comment thread docs/segments/manage_segments.rst
Copy link
Copy Markdown
Contributor

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@promptless-for-oss please address the suggestion.

Comment thread docs/segments/manage_segments.rst Outdated
@promptless-for-oss
Copy link
Copy Markdown
Author

I've addressed the review feedback:

  • RST admonition formatting - Added blank line after .. tip:: directive and changed to 3-space indentation as requested.

@adiati98
Copy link
Copy Markdown
Contributor

@promptless-for-oss please rebase to 7.1

Clarify that relative date values in Segment filters work correctly
regardless of Mautic's language setting. This documents the behavior
fix from mautic/mautic#15791.

- Updated Date options explanation to clarify language display behavior
- Added tip about language-independent Segment evaluation
@promptless-for-oss promptless-for-oss force-pushed the promptless/relative-date-filters-language-support branch from 540185d to 4c2bf74 Compare April 22, 2026 10:20
@promptless-for-oss
Copy link
Copy Markdown
Author

Done! I've rebased the branch onto 7.1. The PR now has a clean commit history on top of the latest 7.1 branch.

@adiati98 adiati98 requested a review from a team April 22, 2026 10:24
@escopecz escopecz requested a review from shinde-rahul April 22, 2026 10:30
Comment thread .github/styles/config/vocabularies/Mautic/accept.txt Outdated
Removes 'rebase' from Vale vocabulary - it was accidentally included during
the branch rebase and is not used in the documentation changes.
@promptless-for-oss
Copy link
Copy Markdown
Author

Good catch! The "rebase" entry in accept.txt was accidentally included during the branch rebase. I've removed it - the PR now contains only the documentation changes to manage_segments.rst.

Copy link
Copy Markdown
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. Although I think this didn't need a doc in the first place. We are just adding a note about "it works in case". Not harmful but I bet users reading this also didn't wonder if it works when using different languages.

Copy link
Copy Markdown
Contributor

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@adiati98 adiati98 merged commit bc8db19 into mautic:7.1 Apr 23, 2026
3 checks passed
@promptless-for-oss promptless-for-oss deleted the promptless/relative-date-filters-language-support branch April 23, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants