Add driver interface for client-space universe offsets#113
Open
pushrax wants to merge 1 commit intomatzman666:masterfrom
Open
Add driver interface for client-space universe offsets#113pushrax wants to merge 1 commit intomatzman666:masterfrom
pushrax wants to merge 1 commit intomatzman666:masterfrom
Conversation
Author
|
This would probably require a protocol version bump too, which is really unfortunate. Would it be better to add a new IPC method instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing WorldFromDriver rotation offset applies directly to
qWorldFromDriverRotationand does not affectvecWorldFromDriverTranslation, which means any changes tovecWorldFromDriverTranslationoriginating from the true device driver will effectively cause the rotation offset to be applied relative to a different origin in client space.In particular, when a lighthouse-tracked device loses tracking and comes up facing a different lighthouse than before, the WorldFromDriver transform will switch, and any calibrated translation offset needs to be adjusted to take this into account. This is fairly annoying when it occurs, and requires either switching the profile, cycling the devices tracking and bringing them up facing the original lighthouse, or restarting SteamVR with the devices facing the original lighthouse.
This PR introduces a new offset, which is effectively applied to the universe transform instead of the WorldFromDriver transform. It does this by applying the rotation offset to the incoming
vecWorldFromDriverTranslationas well asqWorldFromDriverRotation.I'm opening this without any client changes, since I want to gauge your interest in merging before continuing work.