Skip to content

Add --insecure flag to skip TLS certificate validation#61

Merged
mattt merged 3 commits intomainfrom
mattt/insecure
Oct 9, 2025
Merged

Add --insecure flag to skip TLS certificate validation#61
mattt merged 3 commits intomainfrom
mattt/insecure

Conversation

@mattt
Copy link
Owner

@mattt mattt commented Oct 9, 2025

Related to #60

@mattt mattt requested a review from Copilot October 9, 2025 11:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an --insecure flag to skip TLS certificate validation, allowing connections to servers with invalid or self-signed certificates. The implementation involves refactoring the HTTP client configuration to use a structured options approach.

  • Refactored RetryableClient function to accept a structured RetryableClientOptions parameter instead of individual parameters
  • Added TLS certificate verification bypass functionality when the insecure flag is enabled
  • Updated the CLI to include the new --insecure flag and pass it through to both HTTP clients

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
internal/http.go Refactored client creation to use options struct and added insecure TLS configuration
cmd/emcee/main.go Added insecure flag to CLI and updated client instantiation to pass insecure option

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mattt mattt merged commit a533afe into main Oct 9, 2025
1 check passed
@mattt mattt deleted the mattt/insecure branch October 9, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant