Add --insecure flag to skip TLS certificate validation#61
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds an --insecure flag to skip TLS certificate validation, allowing connections to servers with invalid or self-signed certificates. The implementation involves refactoring the HTTP client configuration to use a structured options approach.
- Refactored
RetryableClientfunction to accept a structuredRetryableClientOptionsparameter instead of individual parameters - Added TLS certificate verification bypass functionality when the insecure flag is enabled
- Updated the CLI to include the new
--insecureflag and pass it through to both HTTP clients
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/http.go | Refactored client creation to use options struct and added insecure TLS configuration |
| cmd/emcee/main.go | Added insecure flag to CLI and updated client instantiation to pass insecure option |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #60