fix(transport): Handle multi-line and concatenated JSON-RPC messages#57
Closed
mrchypark wants to merge 1 commit intomattt:mainfrom
Closed
fix(transport): Handle multi-line and concatenated JSON-RPC messages#57mrchypark wants to merge 1 commit intomattt:mainfrom
mrchypark wants to merge 1 commit intomattt:mainfrom
Conversation
Owner
|
Hi @mrchypark. Thanks so much for contributing this PR. emcee pre-dates any community implementations of the MCP spec in Go, and this was also my first introduction to the protocol. So there are a bunch of problems like this. I just merged #58, which swaps in the official Go SDK. This is now available in the latest release (v0.6.0). Can you please give that a try and let me know if you're still seeing this issue? |
Author
|
good to me version 0.6.0 thank you! |
Owner
|
@mrchypark Awesome. Thanks so much for confirming. I'll go ahead and close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue in the Stdio transport where it incorrectly assumes that each JSON-RPC message arrives on a single line. The previous implementation would parse each line break, leading to
Parse errorfor valid, formatted multi-line JSON inputs.This change modifies the reader goroutine in
mcp/transport.goto:{}), while correctly ignoring braces inside string literals.This new approach ensures that
emceecan robustly handle:This significantly improves the usability and robustness of the Stdio transport, making it more resilient to different input formats.