Skip to content

Error improvements #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikeabdullah wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Error improvements #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3401b9
Use +localizedStringForStatusCode: to provide a failure reason for er…
mikeabdullah Nov 1, 2013
ee6a7bf
Use @"org.w3.http" for error domain since they define the HTTP protocol
mikeabdullah Nov 1, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Sources/Core/DAVRequest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ - (void)_didFinish;

@implementation DAVRequest

NSString *const DAVClientErrorDomain = @"com.MattRajca.DAVKit.error";
NSString *const DAVClientErrorDomain = @"org.w3.http";

#define DEFAULT_TIMEOUT 60

Expand Down Expand Up @@ -102,13 +102,14 @@ - (void)connection:(NSURLConnection *)connection didFailWithError:(NSError *)err
- (void)connection:(NSURLConnection *)connection didReceiveResponse:(NSURLResponse *)response {
NSHTTPURLResponse *resp = (NSHTTPURLResponse *)response;
NSInteger code = [resp statusCode];
NSString *description = [resp.class localizedStringForStatusCode:code];

if (code >= 400) {
[_connection cancel];

NSError *error = [NSError errorWithDomain:DAVClientErrorDomain
code:code
userInfo:nil];
userInfo:@{ NSLocalizedFailureReasonErrorKey : description }];

[self _didFail:error];
}
Expand Down