Fix wrong arg count in Exec's "not enough args" error#1398
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
The Exec and Query paths share the same multi-statement loop and the same `len(args)-start < na` check, but the Exec error message was printing `len(args)` instead of `len(args)-start`. With one arg passed to a two-statement query like `SELECT ?; SELECT ?`, the first statement consumes the arg and the second one trips the check, so the "got" count should be 0 (args remaining), not 1 (total args originally passed). The Query path was already correct. This just brings Exec in line. Closes mattn#1395 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1395
ExecandQueryshare the same multi-statement loop and trip the samelen(args)-start < nacheck, but the error messages disagree on the second number. With one arg passed toSELECT ?; SELECT ?:The Query path was already right (args remaining after the first statement consumed one), Exec was printing the total args originally passed in. This just brings Exec in line.
Added a regression test that asserts both paths produce the same message.