You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for splitting this out. The feature itself is welcome — colUsed is a useful planner hint and #1323 is a real gap.
My concern is that changing the VTab.BestIndex signature is a breaking API change. Every external implementer of VTab will fail to compile after upgrading, which we want to avoid in v1.
This repo already uses optional interfaces for extensions (see VTabUpdater, EponymousOnlyModule). Could you take the same approach here? Something like:
In goVBestIndex, type-assert and call BestIndexV2 if implemented, otherwise fall back to the existing BestIndex. That way existing users keep compiling and only those who need colUsed opt in.
Minor: SQLite names the field colUsed (singular) — matching that naming would make the docs easier to follow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #1336 per review feedback.
Summary
sqlite3_index_info.colUsedthrough to the GoVTab.BestIndexcallbackcolsUsedmaskFixes #1323.