Skip to content

Draft: remove support for v5#23

Open
heyjones wants to merge 2 commits intomattmaddux:masterfrom
heyjones:feat/fontawesome-6
Open

Draft: remove support for v5#23
heyjones wants to merge 2 commits intomattmaddux:masterfrom
heyjones:feat/fontawesome-6

Conversation

@heyjones
Copy link
Copy Markdown
Contributor

@heyjones heyjones commented Oct 6, 2023

  • icons.json has been deprecated in favor of icons-families.json
  • i couldn't find a way to swap these out without breaking backwards compatibility

@mattmaddux
Copy link
Copy Markdown
Owner

Interesting. Could make v3 require FA6. How different is the new json file?

@heyjones
Copy link
Copy Markdown
Contributor Author

heyjones commented Oct 6, 2023 via email

@mattmaddux
Copy link
Copy Markdown
Owner

Will try to look into it this weekend and see what I think. I've also
been wanting to change how it processes the json file. Doing at at runtime isn't really ideal and I'd like to investigate how the new Swift macro features might enable it to be pushed to compile-time.

A new file-format might mean it's the right time.

@heyjones
Copy link
Copy Markdown
Contributor Author

heyjones commented Oct 6, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants