Skip to content

perf: prevent leak of first DOM element that uses the mwlResizable directive #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattlewis92 merged 4 commits into from
Dec 17, 2025
Merged

perf: prevent leak of first DOM element that uses the mwlResizable directive #136

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03b072c
Fix leak of Renderer2 instance
nirmal Dec 15, 2025
bfdcb7b
Use a Renderer2 for the Document
nirmal Dec 16, 2025
a3f54b7
Update resizable.directive.ts
nirmal Dec 16, 2025
4613916
fix ci
mattlewis92 Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions projects/angular-resizable-element/src/lib/resizable.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@ import {
NgZone,
PLATFORM_ID,
inject,
RendererFactory2,
} from '@angular/core';
import { isPlatformBrowser } from '@angular/common';
import { DOCUMENT, isPlatformBrowser } from '@angular/common';
import { Subject, Observable, Observer, merge } from 'rxjs';
import {
map,
Expand Down Expand Up @@ -299,12 +300,20 @@ export class ResizableDirective implements OnInit, OnDestroy {

private zone = inject(NgZone);

private rendererFactory = inject(RendererFactory2);

private document = inject(DOCUMENT);

/**
* @hidden
*/
constructor() {
// Create singleton instance of PointerEventListeners to avoid creating
// multiple instances of the same listener. Pass it a renderer for the
// document to avoid renderer for the host element of this directive
// instance.
this.pointerEventListeners = PointerEventListeners.getInstance(
this.renderer,
this.rendererFactory.createRenderer(this.document, null),
this.zone,
);
}
Expand Down