[mattermost-team-edition] add existingSecret for externalDB#467
[mattermost-team-edition] add existingSecret for externalDB#467berlincount wants to merge 1 commit intomattermost:masterfrom
Conversation
|
Hello @berlincount, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
|
Would love to see this feature merged, +1 |
|
Why is this not getting merged? |
|
Guys, this is really sad. I'm currently testing an Enterprise deployment of Mattermost and the lack of attention to this helm chart is really really putting me and my team off. Come on. |
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for externally managed database secrets to the Mattermost Team Edition chart, allowing users to provide their own secrets for external databases.
- Added configuration options for existing external secrets (existingSecret, existingSecretKey) in values.yaml and README.md.
- Updated secret and deployment templates to conditionally use an external DB secret.
- Bumped the chart version for release.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/mattermost-team-edition/values.yaml | Added comments for new external DB secret configuration options. |
| charts/mattermost-team-edition/templates/secret-mattermost-dbsecret.yaml | Conditional logic added for handling an externally provided secret. |
| charts/mattermost-team-edition/templates/deployment.yaml | Updated environment variable secretKeyRef logic to support using an external secret. |
| charts/mattermost-team-edition/README.md | Enhanced documentation with usage examples for externally managed secrets. |
| charts/mattermost-team-edition/Chart.yaml | Incremented chart version from 6.6.60 to 6.6.61. |
Comments suppressed due to low confidence (1)
charts/mattermost-team-edition/templates/secret-mattermost-dbsecret.yaml:16
- [nitpick] The nested quotes in the tpl function may reduce readability and increase the risk of escaping issues. Consider using single quotes for the inner template or refactor the expression to improve clarity.
mattermost.dbsecret: {{ tpl "{{ .Values.externalDB.externalDriverType }}://{{ .Values.externalDB.externalConnectionString }}" . | b64enc }}
|
@berlincount why was this closed? |
Summary
This change adds support for externally managed database secrets, allowing separate encryption or automatic rotation.
Ticket Link
Fixes #456
Fixes #392
Partially addresses #140
Related to #425, things are implemented differently in
mattermost-enterprise-edition, I consider this approach more reliable.