Allow probe scheme to be customised for TLS deployments

[fiddyspence]

… HTTP/S termination options for liveness/readiness/startup probes

Summary

Adds a configuration option and settings in the deployment to facilitate TLS enabled pods

Description

Adds a probeScheme setting in values.yaml which allows the various probes to be either HTTP or HTTPS

Defaults to plain HTTP

Ticket Link

None

[mattermost-build]

Hello @fiddyspence,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

[mattermost-build]

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

[legoguy1000]

we need this to migrate to the helm chart

[Ansible-man]

Given stuff like this is not being reviewed or merged Its a hard sale for my company adopting this application. Either poor management or lack of motivation to maintain the free version of their application. Why would we pay for something when the application cant even be maintained with the code sitting here for free. We would like to deploy this application to test but things like this have to be working first. If the PR needs more work please let me know

[Copilot]

Pull Request Overview

This PR enables customization of probe scheme settings for HTTP/S termination in liveness, readiness, and startup probes.

• Adds a new configuration option probeScheme in values.yaml that defaults to HTTP.
• Applies the probeScheme setting in the deployment template for health and system ping endpoints.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
charts/mattermost-team-edition/values.yaml	Adds a new configuration option with a default probe scheme.
charts/mattermost-team-edition/templates/deployment.yaml	Uses the probeScheme value to set the scheme for HTTP probes.

Comments suppressed due to low confidence (1)

charts/mattermost-team-edition/values.yaml:235

• [nitpick] Consider adding a comment in values.yaml that explicitly lists the allowed values for probeScheme (HTTP or HTTPS) to guide users and prevent configuration errors.

probeScheme: HTTP

[lknite]

I would also like this as I used cloudnative-pg to stand up my postgres server and it by default creates a 'db connection string' to use which fails with mattermost because mattermost was expecting no tls. For my use case, no tls is ok but it would be nice if it were documented to save a few hours of troubleshooting, or at least a log error which really stands out, the existing "unable to connect to db" is helpful, "tls detected when no tls was expected" would be awesome (or better yet a reference to documentation where to enable/disable tls) once this PR (or similar) is merged.