fix-extraEnv-default-value

[ruckc]

Summary

I messed up the default value for extraEnv in #316. This fixes the jobserver.extraEnv to be an array, which is what the template is expecting

Without this change, if trying to use jobserver's extraEnvs, you get this error:

cannot overwrite table with non table for mattermost-enterprise-edition.global.features.jobserver.extraEnv

[mattermod]

Hello @ruckc,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

[ruckc]

the tests need to be retried

[ruckc]

@spirosoik / @pfltdv / @stylianosrigas - can you review?

[spirosoik]

@pfltdv did you give a try to test locally?

[ghost]

@pfltdv did you give a try to test locally?

@spirosoik Yes tested with and without jobserver extra vars. Had no issue at both executions.

[phoinixgrr]

@ruckc

Fine with merging this.

Would you mind also commenting @ values.yaml some examples on how the Jobserver extraEnv directive can be used?
For Example:
https://github.com/mattermost/mattermost-helm/blob/master/charts/mattermost-enterprise-edition/values.yaml#L245-L251

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

[jonathanwiemers]

@ruckc any reason this wasn't merged / updated anymore? Just saw that i've just create a PR for the same issue.

[ruckc]

@jonathanwiemers - no real reason, other than the 3 week lag on feedback. My need for this was removed as we moved away from mattermost due to the integration and license headaches.

[spirosoik]

/update-branch