Skip to content

Decommisioning Rudderstack functionality #8112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cwarnermm wants to merge 1 commit into from
Closed

Decommisioning Rudderstack functionality #8112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
206 changes: 42 additions & 164 deletions source/_static/js/thermometer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/* Mattermost documentation feedback widget */
/* Modified to remove Rudderstack integration and freeform feedback modal */

// Adapted from https://youmightnotneedjquery.com/#on
const jqueryOn = (el, eventName, eventHandler, selector) => {
Expand All @@ -20,24 +21,7 @@ const jqueryOn = (el, eventName, eventHandler, selector) => {
return wrappedHandler;
}
};
// Adapted from https://youmightnotneedjquery.com/#parents
const jqueryParents = (el, selector) => {
const parents = [];
while ((el = el.parentNode) && el !== document) {
if (!selector || el.matches(selector)) parents.push(el);
}
return parents;
};
// Adapted from https://youmightnotneedjquery.com/#val
const jqueryVal = (el) => {
if (el.options && el.multiple) {
return el.options
.filter((option) => option.selected)
.map((option) => option.value);
} else {
return el.value;
}
};

// Adapted from https://youmightnotneedjquery.com/#ready
const jqueryReady = (fn) => {
if (document.readyState !== 'loading') {
Expand All @@ -51,23 +35,15 @@ jqueryReady(() => {
let eventValue = 0;
let rating = '';

// Handle rating selection - now sends analytics immediately
jqueryOn(
document.body,
'click',
(evt) => {
if (evt.target) {
console.debug('set selected from emoji anchor');
evt.target.classList.add('selected');
}
},
'.c-thermometer__emojis a'
);

jqueryOn(
document.body,
'click',
(evt) => {
if (evt.target) {
// Prevent default anchor behavior (jumping to top of page)
evt.preventDefault();

let targetEl = evt.target;
console.debug('clicked a rating');
if (
Expand All @@ -76,7 +52,15 @@ jqueryReady(() => {
) {
targetEl = targetEl.parentElement;
}

// Remove previous selection
document.querySelectorAll('a.rate-this-page-action').forEach((elt) => {
elt.classList.remove('selected');
});

// Add selection to current element
targetEl.classList.add('selected');

const dataRating = targetEl.getAttribute('data-rating');
if (dataRating !== null) {
rating = dataRating;
Expand All @@ -92,150 +76,42 @@ jqueryReady(() => {
eventValue = 1;
break;
}
} else {
eventValue = 0;
console.debug('dataRating was null');
}
document
.querySelectorAll('.c-thermometer-modal__container')
.forEach((elt) => {
console.debug('show container');
elt.style.visibility = 'visible';
});
}
},
'.c-thermometer__emojis a.rate-this-page-action'
);

jqueryOn(
document.body,
'click',
(evt) => {
if (evt.target) {
if (evt.target.classList.contains('btn-link')) {
console.debug('target has class "btn-link"');
jqueryParents(
evt.target,
'.c-thermometer-modal__container'
).forEach((parentElt) => {
console.debug('hide container');
parentElt.style.visibility = 'hidden';
});
document
.querySelectorAll('a.rate-this-page-action')
.forEach((elt) => {
console.debug('remove selected from links');
elt.classList.remove('selected');
});
document
.querySelectorAll(
'.c-thermometer-modal__container textarea'
)
.forEach((elt) => {
console.debug('set value to empty');
elt.value = '';
});
document
.querySelectorAll('.c-thermometer-modal__counter span')
.forEach((elt) => {
elt.innerHTML = '0';
});
return;
}
let currentValue = '';
const textareas = document.querySelectorAll(
'.c-thermometer-modal__container textarea'
);
if (textareas && textareas[0]) {
currentValue = jqueryVal(textareas[0]);
}
console.debug(
`eventValue=${eventValue}, currentValue=${currentValue}`
);
if (currentValue !== '' && eventValue > 0) {
// Google Analytics event
const dataLayer = window.dataLayer || [];
dataLayer.push({
event: 'rateThisPage',
eventLabel: rating,
eventValue: eventValue,
eventFeedback: currentValue,
});
// Rudderstack event
if (typeof rudderanalytics !== 'undefined') {
rudderanalytics.track('feedback_submitted', {
label: rating,
rating: eventValue,
feedback: currentValue,

// Send Google Analytics event immediately (no modal required)
if (eventValue > 0) {
console.debug(`Sending GA event: ${rating} (${eventValue})`);
const dataLayer = window.dataLayer || [];
dataLayer.push({
event: 'rateThisPage',
eventLabel: rating,
eventValue: eventValue,
// No eventFeedback since freeform feedback is disabled
});
}
}
jqueryParents(
evt.target,
'.c-thermometer-modal__container'
).forEach((parentElt) => {
console.debug('hide container');
parentElt.style.visibility = 'hidden';
});
document
.querySelectorAll(
'.c-thermometer-modal__container textarea'
)
.forEach((elt) => {
console.debug('set value to empty');
elt.value = '';
});
document
.querySelectorAll('.c-thermometer-modal__counter span')
.forEach((elt) => {
elt.innerHTML = '0';
});
document
.querySelectorAll('a.rate-this-page-action')
.forEach((elt) => {
console.debug('remove selected from links');
elt.classList.remove('selected');
});
document
.querySelectorAll('.c-thermometer-popup')
.forEach((elt) => {

// Show thank you popup
document.querySelectorAll('.c-thermometer-popup').forEach((elt) => {
console.debug('show popup');
elt.style.display = 'block';
});
setTimeout(() => {
document
.querySelectorAll('.c-thermometer-popup')
.forEach((elt) => {
// Hide popup after 3 seconds
setTimeout(() => {
document.querySelectorAll('.c-thermometer-popup').forEach((elt) => {
console.debug('hide popup');
elt.style.display = 'none';
});
}, 3000);
}, 3000);
} else {
eventValue = 0;
console.debug('dataRating was null');
}
}
},
'.c-thermometer-modal__footer .btn'
'.c-thermometer__emojis a.rate-this-page-action'
);

document
.querySelectorAll('.c-thermometer-modal__container textarea')
.forEach((elt) => {
jqueryOn(elt, 'keyup', (evt) => {
if (evt.target) {
const currentVal = String(jqueryVal(evt.target));
document
.querySelectorAll('.c-thermometer-modal__counter span')
.forEach((elt) => {
elt.innerHTML = currentVal.length.toString();
});
}
});
});

// document.body.addEventListener('click', evt => {
// document.querySelectorAll('.c-thermometer-popup').forEach(elt => {
// console.debug('hide popup from body click');
// elt.style.visibility = 'hidden';
// });
// });
// All modal-related code removed due to Rudderstack decommissioning

jqueryOn(
document.body,
Expand All @@ -249,16 +125,18 @@ jqueryReady(() => {
'.c-thermometer-popup__close'
);

// Prevent event propagation for popup
jqueryOn(
document.body,
'click',
(evt) => {
console.debug('stop event prop from popup');
evt.stopImmediatePropagation();
},
'.c-thermometer__popup'
'.c-thermometer-popup'
);

// Prevent event propagation for trigger
jqueryOn(
document.body,
'click',
Expand All @@ -269,5 +147,5 @@ jqueryReady(() => {
'.c-thermometer__trigger'
);

console.debug('jqueryReady finished');
console.debug('thermometer.js loaded - freeform feedback disabled, GA-only ratings enabled');
});
2 changes: 2 additions & 0 deletions source/_templates/feedback.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<!-- FEEDBACK MODAL DISABLED DUE TO RUDDERSTACK DECOMMISSIONING
<div class="c-thermometer-modal__container">
<div>
<div class="c-thermometer-modal__content">
Expand All @@ -19,6 +20,7 @@ <h3>Tell us more!</h3>
</div>
</div>
</div>
-->
<div class="c-thermometer__group">
<div class="c-thermometer-popup">
<div class="c-thermometer-popup__close">×</div>
Expand Down