Duplicate label/definition detection, and a fix.#10
Open
ProtoSebastian wants to merge 2 commits intomattbatwings:mainfrom
Open
Duplicate label/definition detection, and a fix.#10ProtoSebastian wants to merge 2 commits intomattbatwings:mainfrom
ProtoSebastian wants to merge 2 commits intomattbatwings:mainfrom
Conversation
Added a few lines to detect duplicate labels/definitions and include them in the exit message, so it works with Ado's VM too. I'm pretty sure Matt meant to also make it possible for definitions to have multiple number formats so I changed it to support them too.
Author
|
are labels and definitions supposed to be case-insensitive, btw..? |
Made definition resolution use resolve() so it can use other previously-defined definitions, and ISA-defined symbols like "R0" "R1" or "pixel_x"
ProtoSebastian
commented
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a few lines to detect duplicate labels/definitions and include them in the exit message, so it works with Ado's VM too.
I'm pretty sure Matt meant to also make it possible for definitions to have multiple number formats so I changed it to support them too.