Skip to content

Pass S3 TLS skip verify to mo_br backups #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
volgariver6 merged 1 commit into from
Jun 9, 2026
Merged

Pass S3 TLS skip verify to mo_br backups #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions bin/auto_backup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,10 +403,20 @@ function backup() {
role_arn_option="--role_arn ${BACKUP_S3_ROLE_ARN}"
fi

add_log "D" "Backup command: cd ${BACKUP_MOBR_DIRNAME} && ${BACKUP_MOBR_PATH} backup ${br_meta_option} --parallelism \"${BACKUP_PHYSICAL_PARALLEL_NUM}\" --host \"${MO_HOST}\" --port \"${MO_PORT}\" --user \"${MO_USER}\" --password \"${MO_PW}\" --backup_dir \"s3\" --endpoint \"${BACKUP_S3_ENDPOINT}\" --access_key_id \"${BACKUP_S3_ID}\" --secret_access_key \"${BACKUP_S3_KEY}\" --bucket \"${BACKUP_S3_BUCKET}\" --filepath \"${backup_outpath}\" --region \"${BACKUP_S3_REGION}\" --compression \"${BACKUP_S3_COMPRESSION}\" \"${role_arn_option}\" \"${minio_option}\" ${delta_option}"
cert_files_option=()
if [[ "${BACKUP_S3_CERT_FILES}" != "" ]]; then
cert_files_option=(--cert_files "${BACKUP_S3_CERT_FILES}")
fi

insecure_skip_verify_option=()
if [[ "${BACKUP_S3_INSECURE_SKIP_VERIFY}" == "yes" ]]; then
insecure_skip_verify_option=(--insecure_skip_verify)
fi

add_log "D" "Backup command: cd ${BACKUP_MOBR_DIRNAME} && ${BACKUP_MOBR_PATH} backup ${br_meta_option} --parallelism \"${BACKUP_PHYSICAL_PARALLEL_NUM}\" --host \"${MO_HOST}\" --port \"${MO_PORT}\" --user \"${MO_USER}\" --password \"${MO_PW}\" --backup_dir \"s3\" --endpoint \"${BACKUP_S3_ENDPOINT}\" --access_key_id \"${BACKUP_S3_ID}\" --secret_access_key \"${BACKUP_S3_KEY}\" --bucket \"${BACKUP_S3_BUCKET}\" --filepath \"${backup_outpath}\" --region \"${BACKUP_S3_REGION}\" --compression \"${BACKUP_S3_COMPRESSION}\" \"${role_arn_option}\" \"${minio_option}\" ${cert_files_option[*]} ${insecure_skip_verify_option[*]} ${delta_option}"

startTime=$(get_nanosecond)
if cd ${BACKUP_MOBR_DIRNAME} && ${BACKUP_MOBR_PATH} backup ${br_meta_option} --parallelism "${BACKUP_PHYSICAL_PARALLEL_NUM}" --host "${MO_HOST}" --port "${MO_PORT}" --user "${MO_USER}" --password "${MO_PW}" --backup_dir "s3" --endpoint "${BACKUP_S3_ENDPOINT}" --access_key_id "${BACKUP_S3_ID}" --secret_access_key "${BACKUP_S3_KEY}" --bucket "${BACKUP_S3_BUCKET}" --filepath "${backup_outpath}" --region "${BACKUP_S3_REGION}" --compression "${BACKUP_S3_COMPRESSION}" "${role_arn_option}" "${minio_option}" ${delta_option}; then
if cd ${BACKUP_MOBR_DIRNAME} && ${BACKUP_MOBR_PATH} backup ${br_meta_option} --parallelism "${BACKUP_PHYSICAL_PARALLEL_NUM}" --host "${MO_HOST}" --port "${MO_PORT}" --user "${MO_USER}" --password "${MO_PW}" --backup_dir "s3" --endpoint "${BACKUP_S3_ENDPOINT}" --access_key_id "${BACKUP_S3_ID}" --secret_access_key "${BACKUP_S3_KEY}" --bucket "${BACKUP_S3_BUCKET}" --filepath "${backup_outpath}" --region "${BACKUP_S3_REGION}" --compression "${BACKUP_S3_COMPRESSION}" "${role_arn_option}" "${minio_option}" "${cert_files_option[@]}" "${insecure_skip_verify_option[@]}" ${delta_option}; then
outcome="succeeded"
else
outcome="failed"
Expand Down
3 changes: 2 additions & 1 deletion conf/env.sh.default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,8 @@ BACKUP_S3_REGION=""
BACKUP_S3_COMPRESSION=""
BACKUP_S3_ROLE_ARN=""
BACKUP_S3_IS_MINIO="no"
BACKUP_S3_CERT_FILES=""
BACKUP_S3_INSECURE_SKIP_VERIFY="no"

# 2. logical backups
# mo-dump
Expand Down Expand Up @@ -349,4 +351,3 @@ DATAX_CONF_PATH="/data/tools/datax/conf/test.json"
DATAX_REPORT_FILE="${TOOL_LOG_PATH}/datax.report"
# parameter lists of datax -p option, e.g. 'db_name,table_name'
DATAX_PARA_NAME_LIST=""

4 changes: 4 additions & 0 deletions deploy/k8s/backup-full-cronjob.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ spec:
value: /data/logs/mo_ctl
- name: _CTL_BACKUP_S3_IS_MINIO
value: "yes"
- name: _CTL_BACKUP_S3_CERT_FILES
value: "" # optional: comma-separated CA cert files mounted in the container
- name: _CTL_BACKUP_S3_INSECURE_SKIP_VERIFY
value: "no" # set to "yes" to skip S3 TLS certificate verification

- name: _CTL_CTL_LOG_DIR
value: "/data/logs/mo_ctl/logs"
Expand Down
4 changes: 4 additions & 0 deletions deploy/k8s/backup-incr-cronjob.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ spec:
value: /data/logs/mo_ctl
- name: _CTL_BACKUP_S3_IS_MINIO
value: "yes"
- name: _CTL_BACKUP_S3_CERT_FILES
value: "" # optional: comma-separated CA cert files mounted in the container
- name: _CTL_BACKUP_S3_INSECURE_SKIP_VERIFY
value: "no" # set to "yes" to skip S3 TLS certificate verification

- name: _CTL_CTL_LOG_DIR
value: "/data/logs/mo_ctl/logs"
Expand Down
Loading