fix data branch edge cases#25471
Draft
gouhongshen wants to merge 1 commit into
Draft
Conversation
a9ad0cb to
cbce287
Compare
d60abf9 to
235d65c
Compare
dfa5b12 to
63021a8
Compare
63021a8 to
d32c632
Compare
d32c632 to
94a1b8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #24924
What this PR does / why we need it:
This PR adds and fixes BVT coverage for data branch edge cases from #24924, then fixes the underlying failures found by those cases.
Root causes covered include unsafe clone SQL rewriting for string literals and quoted identifiers, unescaped internal SQL literals for apostrophe identifiers, missing data branch diff/merge/PICK support for decimal256/year/geometry/enum and other edge types, partitioned table change collection panics, unstable PICK validation errors, and explicit transaction rejection for DATA BRANCH DIFF/MERGE.
The changes also update branch_matrix_coverage and branch_unhappy_path expected results after manually checking that the generated results match the intended semantics. The invalid
DATA BRANCH PICK src INTO dstgrammar extension was removed; incomplete PICK syntax remains rejected by the parser.Validation:
@bvt:issue/@skiptags in the three acceptance BVT files below