[4.1-dev] Fix nullable IN-list runtime semantics#25468
Open
LeftHandCold wants to merge 3 commits into
Open
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
ouyuanning
approved these changes
Jul 6, 2026
XuPeng-SH
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #25346
Follow-up to #25426.
What this PR does / why we need it:
The previous zonemap fix made block pruning conservative for nullable IN lists, but the SQL path can still fail before row-level filtering. Planner constant folding converts
INlist literals into a folded vector.Vector.InplaceSortAndCompact()sorts the vector payload without moving the null bitmap, so('keep', NULL)can become a vector where the null bitmap no longer points at the same value. The runtimeinoperator then skips the wrong RHS slot while building its hash map, andWHERE k IN ('keep', NULL)can filter out matchingkeeprows.This PR fixes the full path for 4.1-dev:
IN/NOT INreturn SQL UNKNOWN for no-match rows when the RHS contains NULL;AnyIn.Validated with the issue-shaped SQL on a dev node:
Local checks: