fix(fileservice): avoid closing idle upload connections (#25458)#25463
Merged
mergify[bot] merged 1 commit intoJul 6, 2026
Merged
Conversation
…#25458) `LOAD DATA` from COS can intermittently fail with `http: server closed idle connection` during long multipart uploads. The fileservice HTTP transport already has `IdleConnTimeout` and connection limits, but the background metrics cleanup loop was also calling `CloseIdleConnections()` every 5s, which can close an idle upload connection between multipart requests. Changes: - stop periodically calling `httpTransport.CloseIdleConnections()` from the fileservice background loop - keep stale connection metric cleanup, using `IdleConnTimeout + 2s` as the stale metric threshold - treat `server closed idle connection` as retryable so existing COS retry wrappers can retry this transient transport error - add retryability coverage for the COS error string Validation: ```text go build ./pkg/fileservice go vet ./pkg/fileservice go test -v -count=1 ./pkg/fileservice PASS ok github.com/matrixorigin/matrixone/pkg/fileservice 27.250s ``` Approved by: @XuPeng-SH
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
XuPeng-SH
approved these changes
Jul 6, 2026
Contributor
Merge Queue Status
This pull request spent 11 seconds in the queue, including 1 second running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
Fixes #25350
Related to #23225
Related to #24916
What this PR does / why we need it:
LOAD DATAfrom COS can intermittently fail withhttp: server closed idle connectionduring long multipart uploads. The fileservice HTTP transport already hasIdleConnTimeoutand connection limits, but the background metrics cleanup loop was also callingCloseIdleConnections()every 5s, which can close an idle upload connection between multipart requests.Changes:
httpTransport.CloseIdleConnections()from the fileservice background loopIdleConnTimeout + 2sas the stale metric thresholdserver closed idle connectionas retryable so existing COS retry wrappers can retry this transient transport error