Update Lat Long storage to 2dp to meet privacy requirements

[nathangavin]

Description:

Current latitude/longitude data is stored at 3 decimal places. This is considered too accurate for privacy reasons, and so this update changes the accuracy of stored latitude/longitude data to only 2 decimal places.

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[caddoo]

@nathangavin I can see more tests failing because the test files haven't been updated.

For example test testAnonymizeInformationRestrictSites is failing and the anonymizeVisitInformation_restrictSites.json file being tested doesn't have the correct lat/long stored.

I used GPT to create a grep cli command to search for test files (json) that have more than 2dp rounding.

grep -r --include='*.json' -E '"[a-zA-Z_]*itude":\s*"[0-9]+\.[0-9]{4,}"' ./ | grep '/tests/'

Hope this helps

[nathangavin]

Using commands:

grep -r --include='*.xml' -E '<[a-zA-Z_]*itude>\s*[0-9]+\.[0-9]{2}[1-9][0-9]*\s*</[a-zA-Z_]*itude>' ./ | grep '/tests/'

along with Matts suggested command:

grep -r --include='*.json' -E '"[a-zA-Z_]*itude":\s*"[0-9]+\.[0-9]{4,}"' ./ | grep '/tests/'

I am pretty confident I have updated all expected test files, however some tests are still failing. The tests are seeming to use the previous expected files, before my changes. Is anyone able to determine why this is happening?

[sgiehl]

The custom variables plugin is a submodule. They need to be updated in another repo and the submodule reference needs to be updated then. You can ignore that for now. Should be fine to update them after this PR was reviewed.

[sgiehl]

Works as expected.
I've created matomo-org/plugin-CustomVariables#106 to adjust the tests for the submodule.
Once that's merged we can update the submodule reference here and merge the PR.