Skip to content

Conversation

@Findus23
Copy link
Collaborator

@Findus23 Findus23 commented Feb 4, 2020

Third time's a charm :)

This is a recreation of #213 using the latest version of Slim 4 that again changed quite a lot of things.

This only includes the most important changes to get Slim 4 working, any other improvement to the site will come in later pull requests to keep this small.

  • updated Slim to 4
  • updated Twig to 3.x
  • use latest michelf/php-markdown
  • requires at least PHP 7.2.0
  • also cache json routes
  • use proper file extensions for cache files
  • don't cache if page contains failed request
  • cache routing to tmp/cache/route_cache.php
  • completely rewritten app/public/index.php as it contains the slim-specific logic
  • lots of reformatting in app/routes/page.php to have routes in new format
  • partly revert Remove docs for Piwik 2 #277 (show search again in navbar)
  • minor change in app/public/js/app.js to make search work again.

I'm still totally confused by Dependeny Injection so this is written in a "normal" style instead of as recommended in https://github.com/slimphp/Slim-Skeleton/blob/master/public/index.php.

A demo page running this branch can be found at https://matomodocs.lw1.at/

@Findus23 Findus23 marked this pull request as ready for review February 4, 2020 19:58
@mattab mattab requested a review from tsteur February 4, 2020 23:28
@tsteur tsteur merged commit 9230950 into master Feb 5, 2020
@tsteur tsteur deleted the slim4 branch February 5, 2020 00:20
@tsteur
Copy link
Member

tsteur commented Feb 5, 2020

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants