Skip to content

Update eff.opam for OCaml 5.2#88

Open
ncihnegn wants to merge 4 commits intomatijapretnar:masterfrom
ncihnegn:patch-1
Open

Update eff.opam for OCaml 5.2#88
ncihnegn wants to merge 4 commits intomatijapretnar:masterfrom
ncihnegn:patch-1

Conversation

@ncihnegn
Copy link

@ncihnegn ncihnegn commented Dec 1, 2024

No description provided.

@matijapretnar
Copy link
Owner

Hmmm, I think the GitHub actions need to be updated as well. Also, I prefer to have the OCamlformat version fixed, otherwise the testing is unpredictable. Can you recommend a version that works on OCaml 5, but is still supported on some version of OCaml 4?

@ncihnegn
Copy link
Author

ncihnegn commented Dec 4, 2024

I don't see why CI will fail. Could you please retry it?

@matijapretnar
Copy link
Owner

I think the problem is that this line in GitHub script installs OCaml 4:

uses: avsm/setup-ocaml@v1

@matijapretnar
Copy link
Owner

The tests now fail with

dune build @fmt --auto-promote
File "dune-project", line 22, characters 2-15:
22 |   (ocamlformat)))
       ^^^^^^^^^^^^^
Error: Atom or quoted string expected
make: *** [Makefile:6: format] Error 1

I think it would be best to keep a fixed version of OCamlformat, preferably one that works with both OCaml 4 and 5, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants