Addressed review comments

Author: diningPhilosopher64

src/jupyter_matlab_kernel/kernels/__init__.py

@@ -2,6 +2,4 @@
 
 from .jsp_kernel import MATLABKernelUsingJSP
 from .mpm_kernel import MATLABKernelUsingMPM
-from .kernel_factory import KernelFactory
-
-__all__ = ["MATLABKernelUsingJSP", "MATLABKernelUsingMPM", "KernelFactory"]
+from .kernel_factory import KernelFactory

src/jupyter_matlab_kernel/kernels/base_kernel.py

@@ -13,7 +13,6 @@
 import time
 from logging import Logger
 from pathlib import Path
-from typing import Optional
 
 import aiohttp
 import aiohttp.client_exceptions
@@ -78,7 +77,7 @@ def _fetch_jupyter_base_url(parent_pid: str, logger: Logger) -> str:
     return ""
 
 
-def _get_parent_pid(logger) -> int:
+def _get_parent_pid() -> int:
     """
     Retrieves the parent process ID (PID) of the Kernel process.
 

src/jupyter_matlab_kernel/kernels/kernel_factory.py

@@ -3,8 +3,8 @@
 import os
 from typing import Union
 
-from jupyter_matlab_kernel.kernels.jsp_kernel import MATLABKernelUsingJSP
-from jupyter_matlab_kernel.kernels.mpm_kernel import MATLABKernelUsingMPM
+from jupyter_matlab_kernel.kernels import MATLABKernelUsingJSP
+from jupyter_matlab_kernel.kernels import MATLABKernelUsingMPM
 
 
 class KernelFactory:

src/jupyter_matlab_kernel/kernels/labextension_comm/communication.py

@@ -11,6 +11,10 @@ def __init__(self, kernel):
 
     def comm_open(self, stream, ident, msg):
         """Handler to execute when labextension sends a message with 'comm_open' type ."""
+
+        # As per jupyter messaging protocol https://jupyter-client.readthedocs.io/en/latest/messaging.html#custom-messages
+        # 'content' will be present in msg, 'comm_id' and 'target_name' will be present in content.
+
         content = msg["content"]
         comm_id = content["comm_id"]
         target_name = content["target_name"]
@@ -27,6 +31,9 @@ async def comm_msg(self, stream, ident, msg):
 
     def comm_close(self, stream, ident, msg):
         """Handler to execute when labextension sends a message with 'comm_close' type."""
+
+        # As per jupyter messaging protocol https://jupyter-client.readthedocs.io/en/latest/messaging.html#custom-messages
+        # 'content' will be present in msg, 'comm_id' and 'data' will be present in content.
         content = msg["content"]
         comm_id = content["comm_id"]
         comm = self.comms.get(comm_id)
@@ -36,4 +43,4 @@ def comm_close(self, stream, ident, msg):
             del self.comms[comm_id]
 
         else:
-            self.log.warning(f"Attempted to close unknown comm_id: {comm_id}")
+            self.log.debug(f"Attempted to close unknown comm_id: {comm_id}")

src/jupyter_matlab_kernel/mwi_comm_helpers.py

@@ -385,6 +385,9 @@ async def _send_jupyter_request_to_matlab(self, request_type, inputs, http_clien
             resp = await self._send_feval_request_to_matlab(
                 http_client, "processJupyterKernelRequest", 1, *inputs
             )
+
+        # The 'else' condition is an artifact and is present here incase we ever want to test
+        # eval execution. 
         else:
             user_mcode = inputs[2]
             # Construct a string which can be evaluated in MATLAB. For example

src/jupyter_matlab_labextension/.eslintrc.json

@@ -1,44 +1,41 @@
-
 {
   "root": true,
   "parser": "@typescript-eslint/parser",
   "parserOptions": {
-      "ecmaVersion": 6,
-      "sourceType": "module"
+    "ecmaVersion": 6,
+    "sourceType": "module"
   },
   "env": {
     "jest": true
   },
   "plugins": ["@typescript-eslint"],
   "extends": ["standard"],
   "rules": {
-      "indent": ["error", 4, { "SwitchCase": 1 }],
-      "semi": ["error", "always"],
-      "no-extra-semi": "error",
-      "quote-props": "warn",
-      "dot-notation": "warn",
-      "object-curly-newline": "warn",
-      "multiline-ternary": "warn",
-      "prefer-const": "warn",
-      "no-prototype-builtins": "warn",
-      "array-callback-return": "warn",
-      "array-bracket-spacing": "warn",
-      "quotes": "warn",
-      "lines-between-class-members": "warn",
-      "no-empty": "warn",
-      "prefer-regex-literals": "warn",
-      "no-useless-catch": "warn",
-      "no-case-declarations": "warn",
-      "computed-property-spacing": "warn",
-      "no-async-promise-executor": "warn",
-      "no-unused-vars": "warn",
-      "no-unreachable-loop": "warn",
-      "no-void": "warn",
-      "import/no-webpack-loader-syntax": "warn",
-      "node/no-callback-literal": ["off", "warn"],
-      "node/handle-callback-err": ["off", "warn"],
-      "node/no-deprecated-api": ["off", "warn"]
+    "indent": ["error", 4, { "SwitchCase": 1 }],
+    "semi": ["error", "always"],
+    "no-extra-semi": "error",
+    "quote-props": "warn",
+    "dot-notation": "warn",
+    "object-curly-newline": "warn",
+    "multiline-ternary": "warn",
+    "prefer-const": "warn",
+    "no-prototype-builtins": "warn",
+    "array-callback-return": "warn",
+    "array-bracket-spacing": "warn",
+    "quotes": "warn",
+    "lines-between-class-members": "warn",
+    "no-empty": "warn",
+    "prefer-regex-literals": "warn",
+    "no-useless-catch": "warn",
+    "no-case-declarations": "warn",
+    "computed-property-spacing": "warn",
+    "no-async-promise-executor": "warn",
+    "no-unused-vars": "warn",
+    "no-unreachable-loop": "warn",
+    "no-void": "warn",
+    "import/no-webpack-loader-syntax": "warn",
+    "node/no-callback-literal": ["off", "warn"],
+    "node/handle-callback-err": ["off", "warn"],
+    "node/no-deprecated-api": ["off", "warn"]
   }
 }
-
-

src/jupyter_matlab_labextension/.styleintrc.json

@@ -1,19 +1,19 @@
 // Copyright 2025 The MathWorks, Inc.
 module.exports = {
-  preset: 'ts-jest',
-  testEnvironment: 'node',
-  testMatch: ['**/tests/**/*.ts?(x)', '**/?(*.)+(spec|test).ts?(x)'],
-  testPathIgnorePatterns: ['/node_modules/', '/src/tests/jest-setup.ts'],
-  moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx', 'json', 'node'],
-  setupFilesAfterEnv: ['<rootDir>/src/tests/jest-setup.ts'],
+  preset: "ts-jest",
+  testEnvironment: "node",
+  testMatch: ["**/tests/**/*.ts?(x)", "**/?(*.)+(spec|test).ts?(x)"],
+  testPathIgnorePatterns: ["/node_modules/", "/src/tests/jest-setup.ts"],
+  moduleFileExtensions: ["ts", "tsx", "js", "jsx", "json", "node"],
+  setupFilesAfterEnv: ["<rootDir>/src/tests/jest-setup.ts"],
   transform: {
-    '^.+\\.(ts|tsx)$': 'ts-jest'
+    "^.+\\.(ts|tsx)$": "ts-jest",
   },
   transformIgnorePatterns: [
-    '/node_modules/(?!(@jupyterlab)/)' // Transform @jupyterlab packages
+    "/node_modules/(?!(@jupyterlab)/)", // Transform @jupyterlab packages
   ],
   moduleNameMapper: {
     // Mock @jupyterlab/ui-components to avoid ES modules issues
-    '@jupyterlab/ui-components': '<rootDir>/src/tests/mocks/ui-components.js'
-  }
-};
+    "@jupyterlab/ui-components": "<rootDir>/src/tests/mocks/ui-components.js",
+  },
+};

src/jupyter_matlab_labextension/jest.config.js

@@ -85,7 +85,6 @@
     "prettier": "^2.8.7",
     "rimraf": "^4.4.1",
     "semver": ">=5.7.2",
-    "stylelint": "^16.18.0",
     "ts-jest": "^29.2.5",
     "typescript": "~5.0.2",
     "ws": "^7.5.10",

src/jupyter_matlab_labextension/package.json

@@ -1,13 +1,21 @@
 // Copyright 2024-2025 The MathWorks, Inc.
 
 import { parser } from '../lezer-matlab/dist/index';
-import { indentNodeProp, LanguageSupport, LRLanguage, TreeIndentContext } from '@codemirror/language';
+import {
+    indentNodeProp,
+    LanguageSupport,
+    LRLanguage,
+    TreeIndentContext
+} from '@codemirror/language';
 import { lineIndent, getDedentPattern } from './indent-matlab';
 
 function determineLineIndent (context: TreeIndentContext) {
-    if (context.pos === 0) { return null; }
+    if (context.pos === 0) {
+        return null;
+    }
     const currentLine = context.lineAt(context.pos);
-    const previousLine = currentLine.text.length === 0
+    const previousLine =
+    currentLine.text.length === 0
         ? context.lineAt(context.pos, -1) // Look to the left of the simulated line break.
         : context.lineAt(context.pos - 1); // Not on a simulated line break, so step back to the previous line.
     if (previousLine === null || currentLine === null) {