Addressed review comments

Author: diningPhilosopher64

src/jupyter_matlab_kernel/__main__.py

@@ -1,4 +1,4 @@
-# Copyright 2023-2024 The MathWorks, Inc.
+# Copyright 2023-2025 The MathWorks, Inc.
 # Use ipykernel infrastructure to launch the MATLAB Kernel.
 
 if __name__ == "__main__":

src/jupyter_matlab_kernel/kernels/base_kernel.py

@@ -92,8 +92,6 @@ def _get_parent_pid(logger) -> int:
     """
     parent_pid = os.getppid()
 
-    logger.info("Type ", type(parent_pid), " parent pid ", parent_pid)
-
     # Note: conda environments do not require this, and for these environments
     # sys.prefix == sys.base_prefix
     is_virtual_env = sys.prefix != sys.base_prefix

src/jupyter_matlab_kernel/kernels/jsp_kernel.py

@@ -1,4 +1,4 @@
-# Copyright 2024 The MathWorks, Inc.
+# Copyright 2024-2025 The MathWorks, Inc.
 
 """This module contains derived class implementation of MATLABKernel that uses
 Jupyter Server to manage interactions with matlab-proxy & MATLAB.

src/jupyter_matlab_kernel/kernels/labextension_comm/communication.py

@@ -23,23 +23,7 @@ def comm_open(self, stream, ident, msg):
 
     async def comm_msg(self, stream, ident, msg):
         """Handler to execute when labextension sends a message with 'comm_msg' type."""
-
-        content = msg["content"]
-        data = content["data"]
-        action_type = data["action"]
-        payload = data["data"]
-        comm_id = content["comm_id"]
-        comm = self.comms.get(comm_id)
-
-        if not comm:
-            self.log.error(
-                "Received comm_msg but no communication channel is available"
-            )
-            raise Exception("No Communcation channel available")
-
-        self.log.debug(
-            f"Received action_type:{action_type} with data:{payload} from the lab extension"
-        )
+        pass
 
     def comm_close(self, stream, ident, msg):
         """Handler to execute when labextension sends a message with 'comm_close' type."""

src/jupyter_matlab_kernel/mwi_comm_helpers.py

@@ -179,6 +179,13 @@ async def send_shutdown_request_to_matlab(self):
         )
 
     async def send_interrupt_request_to_matlab(self):
+        """Send an interrupt request to MATLAB to stop current execution.
+
+        The interrupt request is sent through the control channel using a specific message format.
+
+        Raises:
+            HTTPError: If the interrupt request fails or matlab-proxy communication errors occur
+        """
         self.logger.debug("Sending interrupt request to MATLAB")
         req_body = {
             "messages": {
@@ -201,6 +208,24 @@ async def send_interrupt_request_to_matlab(self):
             resp.raise_for_status()
 
     async def _send_feval_request_to_matlab(self, http_client, fname, nargout, *args):
+        """Execute a MATLAB function call (feval) through the matlab-proxy.
+
+        Sends a function evaluation request to MATLAB, handling path setup and synchronous execution.
+
+        Args:
+            http_client (aiohttp.ClientSession): HTTP client for sending the request
+            fname (str): Name of the MATLAB function to call
+            nargout (int): Number of output arguments expected
+            *args: Variable arguments to pass to the MATLAB function
+
+        Returns:
+            list: Results from the MATLAB function execution if successful
+                 Empty list if no outputs or nargout=0
+
+        Raises:
+            MATLABConnectionError: If MATLAB connection is lost or response is invalid
+            Exception: If function execution fails or is interrupted by user
+        """
         self.logger.debug("Sending FEval request to MATLAB")
         # Add the MATLAB code shipped with kernel to the Path
         path = [str(pathlib.Path(__file__).parent / "matlab")]
@@ -265,9 +290,35 @@ async def _send_feval_request_to_matlab(self, http_client, fname, nargout, *args
             raise resp.raise_for_status()
 
     async def send_eval_request_to_matlab(self, mcode):
+        """Send an evaluation request to MATLAB using the shell client.
+
+        Args:
+            mcode (str): MATLAB code to be evaluated
+
+        Returns:
+            dict: The evaluation response from MATLAB containing results or error information
+
+        Raises:
+            MATLABConnectionError: If MATLAB connection is not available
+            HTTPError: If there is an error in communication with matlab-proxy
+        """
         return await self._send_eval_request_to_matlab(self._http_shell_client, mcode)
 
     async def _send_eval_request_to_matlab(self, http_client, mcode):
+        """Internal method to send and process an evaluation request to MATLAB.
+
+        Args:
+            http_client (aiohttp.ClientSession): HTTP client to use for the request
+            mcode (str): MATLAB code to be evaluated
+
+        Returns:
+            dict: The evaluation response containing results or error information
+                 from the MATLAB execution
+
+        Raises:
+            MATLABConnectionError: If MATLAB connection is not available or response is invalid
+            HTTPError: If there is an error in communication with matlab-proxy
+        """
         self.logger.debug("Sending Eval request to MATLAB")
         # Add the MATLAB code shipped with kernel to the Path
         path = str(pathlib.Path(__file__).parent / "matlab")
@@ -307,6 +358,20 @@ async def _send_eval_request_to_matlab(self, http_client, mcode):
             raise resp.raise_for_status()
 
     async def _send_jupyter_request_to_matlab(self, request_type, inputs, http_client):
+        """Process and send a Jupyter request to MATLAB using either feval or eval execution.
+
+        Args:
+            request_type (str): Type of request (execute, complete, shutdown)
+            inputs (list): List of input arguments for the request
+            http_client (aiohttp.ClientSession): HTTP client to use for the request
+
+        Returns:
+            dict: Response from MATLAB containing results of the request execution
+
+        Raises:
+            MATLABConnectionError: If MATLAB connection is not available
+            Exception: If request execution fails or is interrupted
+        """
         execution_request_type = "feval"
 
         inputs.insert(0, request_type)
@@ -347,6 +412,18 @@ async def _send_jupyter_request_to_matlab(self, request_type, inputs, http_clien
         return resp
 
     async def _read_eval_response_from_file(self, eval_response):
+        """Read and process MATLAB evaluation results from a response file.
+
+        Args:
+            eval_response (dict): Response dictionary from MATLAB eval request containing
+                                file path and error information
+
+        Returns:
+            dict: JSON decoded results from the response file
+
+        Raises:
+            Exception: If evaluation failed or was interrupted by user
+        """
         # If the eval request succeeded, return the json decoded result.
         if not eval_response["isError"]:
             result_filepath = eval_response["responseStr"].strip()

src/jupyter_matlab_labextension/src/index.ts

@@ -1,4 +1,4 @@
-// Copyright 2023-2024 The MathWorks, Inc.
+// Copyright 2023-2025 The MathWorks, Inc.
 
 import { JupyterFrontEndPlugin } from '@jupyterlab/application';
 import { matlabToolbarButtonPlugin } from './plugins/matlabToolbarButton';

src/jupyter_matlab_labextension/src/plugins/matlabCM6Mode.ts

@@ -1,4 +1,4 @@
-// Copyright 2023-2024 The MathWorks, Inc.
+// Copyright 2023-2025 The MathWorks, Inc.
 
 // Set up CodeMirror for the MATLAB language.
 

src/jupyter_matlab_labextension/src/plugins/matlabFiles.ts

@@ -1,4 +1,4 @@
-// Copyright 2023-2024 The MathWorks, Inc.
+// Copyright 2023-2025 The MathWorks, Inc.
 
 // Create a command to open a new .m file.
 // Add this command to the Launcher (under "Other"),

src/jupyter_matlab_labextension/src/tests/jest-setup.ts

@@ -1,4 +1,4 @@
-// Copyright 2023 The MathWorks, Inc.
+// Copyright 2025 The MathWorks, Inc.
 
 // Mock global objects that might not be available in the Node.js environment
 

src/jupyter_matlab_labextension/src/tests/matlabToolbarButton.test.ts

@@ -1,4 +1,4 @@
-// Copyright 2023 The MathWorks, Inc.
+// Copyright 2025 The MathWorks, Inc.
 
 // Mock the icons module
 jest.mock('../icons', () => ({