fix: correct tab group indicator placement for bottom header position#1229
Open
KyDenZ wants to merge 1 commit into
Open
fix: correct tab group indicator placement for bottom header position#1229KyDenZ wants to merge 1 commit into
KyDenZ wants to merge 1 commit into
Conversation
KyDenZ
force-pushed
the
fix/tab-group-indicator-bottom-position
branch
from
6068c37 to
55d6ee0
Compare
Owner
|
@KyDenZ sorry, been doing a little refactoring. would you be able to fixup the merge conflict and then I'll look at merging in |
KyDenZ
force-pushed
the
fix/tab-group-indicator-bottom-position
branch
from
55d6ee0 to
888f7ba
Compare
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When tabs are positioned at the bottom, the group indicator now renders at the top edge of the tab bar, adjacent to the content area, matching Chrome's tab group behavior.
Also fix the ::after active tab marker direction in bottom header mode, and add a top/bottom/left/right position selector to the tab-groups sandbox