Skip to content

fix(#226): incorrect height reported when UIAccessibilityPrefersCrossFadeTransitions is enabled #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateusz1913 merged 1 commit into from
Jun 28, 2025
+8 −0
Merged

fix(#226): incorrect height reported when UIAccessibilityPrefersCrossFadeTransitions is enabled #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/react-native-avoid-softinput/ios/AvoidSoftInputListener.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,14 @@ - (void)softInputHeightWillChange:(NSNotification *)notification
BOOL isOrientationChange = screenHeight != previousScreenHeight;

CGFloat newSoftInputHeight = screenHeight - softInputUserInfo.CGRectValue.origin.y;

/// https://github.com/mateusz1913/react-native-avoid-softinput/issues/226
/// The frame can be zero, when UIAccessibility.prefersCrossFadeTransitions setting is enabled
/// In that case, let's default to "closed" keyboard value
if (softInputUserInfo.CGRectValue.origin.y == 0) {
newSoftInputHeight = 0;
}

// notification begin frame info is not reliable, so instead get previous cached value
CGFloat oldSoftInputHeight = previousSoftInputHeight;

Expand Down
Loading