A possible issue with not deepcopying job kwargs#860
Open
vineetbansal wants to merge 2 commits intomaterialsproject:mainfrom
Open
A possible issue with not deepcopying job kwargs#860vineetbansal wants to merge 2 commits intomaterialsproject:mainfrom
vineetbansal wants to merge 2 commits intomaterialsproject:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we discovered when working towards another PR, mutating one job's config mutates all others created by that decorator. This is because the
@jobdecorator keeps a reference tojob_kwargsinstead of deep-copying it. This may or may not be an issue, and may just need explicit documentation.This PR introduces an
xfailtest to demonstrate this behavior. The solution suggested by @gpetretto which should solve this is: