Open
Conversation
alexander-ignatow
suggested changes
Apr 16, 2025
alexander-ignatow
left a comment
alexander-ignatow
left a comment
There was a problem hiding this comment.
Please, make sure the demo link is working
And take a look at the minor issues, spotted
src/styles/blocks/_faq.scss
Outdated
Comment on lines
1
to
9
| .faq { | ||
| background: rgba(0, 0, 0, 0.7); | ||
| overflow: auto; | ||
| width: 100vw; | ||
| height: 100vh; | ||
|
|
||
| &__main { | ||
| background-color: rgba(25, 21, 54, 1); | ||
| height: 100%; |
There was a problem hiding this comment.
It makes sense move these colors to the constants, as toy use them multiple times
src/styles/blocks/_more.scss
Outdated
| @@ -0,0 +1,21 @@ | |||
| .more { | |||
| background-color: rgba(5, 4, 11, 1); | |||
src/styles/main.scss
Outdated
Comment on lines
33
to
35
| body { | ||
| background: $c-gray; | ||
| background: linear-gradient(100.83deg, #191536 0.67%, #000 100%); | ||
| box-shadow: 4px 4px 40px 0 rgba(0, 0, 0, 0.25); |
There was a problem hiding this comment.
It makes sense to have body styles reset, while background and box-shadow should be moved to a diferent container, or at least to the class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://kami2693.github.io/layout_KateVR/