Add additional configuration for redis secrets#201
Open
timetinytim wants to merge 17 commits intomainfrom
Open
Add additional configuration for redis secrets#201timetinytim wants to merge 17 commits intomainfrom
timetinytim wants to merge 17 commits intomainfrom
Conversation
renchap
reviewed
Aug 12, 2025
| name: {{ template "mastodon.redis.secretName" . }} | ||
| {{- end }} | ||
| key: redis-password | ||
| key: {{ .Values.redis.auth.existingSecretKey }} |
Member
There was a problem hiding this comment.
I think it would be better to have both name and key (the whole secretKeyRef be from a template, rather than repeating this everywhere?
Contributor
Author
There was a problem hiding this comment.
That's honestly not a bad idea. I'll make that change.
Contributor
Author
There was a problem hiding this comment.
Except I can see one issue with this.
The current solution allows it to be backwards compatible with the way it's already done. This new solution would basically mean either replacing existingSecret with that new format, which would break existing setups, or creating a new field like existingSecretRef, which wouldn't break anything, but would be somewhat redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows users to set the existing secret key for redis instances. Default values are still set in such a way that the chart will behave the same as before by default.
This change makes it easier for me personally to set up some new infrastructure in a way that's better conforms to standards.