refactor: replace string formatting with url.URL to support ipv6#180
Merged
masterzen merged 1 commit intomasterzen:masterfrom Aug 19, 2025
Merged
refactor: replace string formatting with url.URL to support ipv6#180masterzen merged 1 commit intomasterzen:masterfrom
masterzen merged 1 commit intomasterzen:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the endpoint URL construction to use Go's url.URL type instead of string formatting for better URL handling and IPv6 compatibility.
- Replaces
fmt.Sprintfwith structured URL building usingurl.URL - Uses
net.JoinHostPortfor proper host:port formatting that handles IPv6 addresses - Removes dependency on the
fmtpackage
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#179 179