[X-2935] Bump arrow-datafusion rev to 3e6bcf2#50
Merged
Conversation
Picks up the nested DynamicFilterPhysicalExpr snapshot-walker fix (massive-com/arrow-datafusion#62) on branch-53.
There was a problem hiding this comment.
Pull request overview
Bumps the pinned massive-com/arrow-datafusion git revision used by this crate to pick up upstream fixes to physical expr serialization, specifically preserving nested DynamicFilterPhysicalExpr wrappers through serialize_physical_expr_with_converter’s snapshot walk (needed for correct dynamic filter behavior over the wire).
Changes:
- Update all DataFusion-related git dependencies to rev
3e6bcf2045801d4bd178b18497be4644617ed00a.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up massive-com/arrow-datafusion#62, which preserves nested
DynamicFilterPhysicalExprwrappers throughserialize_physical_expr_with_converter's snapshot walk. Required so atlas can bump to a DF rev that doesn't foldBinaryExpr(AND, static_WHERE, dyn_filter)to a static literal on the wire.Affects
3e6bcf2045801d4bd178b18497be4644617ed00aValidation
DF-side tests verified in apache/datafusion#62: 5/5
dynamic_filter*proto roundtrip tests pass, including the newdynamic_filter_nested_in_binary_expr_survives_proto_roundtripregression.