Drop CopyInstanceInput.Message (field removed from V2 schema)#24
Merged
Conversation
The V2 `copyInstance` mutation's input dropped `message` (it was an
accidental addition that didn't belong on a pure copy operation —
plan deployments carry their own message via createDeployment). The
generated client still carried `Message string` with no omitempty
tag, so every call serialized `"message": ""` and the server
rejected the whole input with:
Argument "input" has invalid value $input.
In field "message": Unknown field.
Regenerate against the current prod schema (massdriver/internal/gen
catches up on the cleanup) and drop `Message` from the public
instances.CopyInput. Test fixture stops passing the removed field.
Fixes #23.
chrisghill
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copyInstanceis broken in the current SDK build: every call fails at the GraphQL parser before reaching the resolver.The V2 schema dropped
messagefromCopyInstanceInput— copy is a pure config-staging operation; messages live on thecreateDeploymentthat follows. The SDK was generated whenmessagewas on the input and still carries it, with noomitempty, so every call marshals\"message\": \"\"and gets rejected.This regenerates the genqlient client against the current prod schema and drops
Messagefrom the publicinstances.CopyInput.Changes
massdriver/internal/gen/schema.graphql— refreshed fromhttps://api.massdriver.cloud/graphql/v2/schema.graphql.CopyInstanceInputlosesmessage.massdriver/internal/gen/zz_generated.go— regenerated (make generate).CopyInstanceInputstruct + getters + (un)marshal helpers dropMessage.massdriver/platform/instances/instances.go— dropMessage stringfromCopyInput; drop it from the gen-level mapping inService.Copy.massdriver/platform/instances/instances_test.go— fixture stops settingMessage.Test plan
go build ./...go test ./...— all packages greenFixes #23. Unblocks massdriver-cloud/mass#236 and massdriver-cloud/mass#238.