remove requirement to scope artifact definitions to an org #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the requirement for artifact definitions to be scoped with an organization prefix, allowing users to reference artifacts by name only (e.g., test-schema) instead of requiring the full qualified name (e.g., massdriver/test-schema).
Key Changes:
- Updated regex pattern to make the organization prefix optional in artifact definition references
- Added logic to automatically prepend the organization ID when a name without a prefix is provided
- Added test coverage for dereferencing schemas without org prefix
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/bundle/dereference.go | Modified regex pattern to make org prefix optional in artifact definition references |
| pkg/api/artifact_definitions.go | Added logic to automatically prepend organization ID when name lacks a prefix |
| pkg/bundle/dereference_test.go | Added test case for dereferencing remote refs without org prefix |
| pkg/api/artifact_definitions_test.go | Added assertion to verify the artifact definition query parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
coryodaniel
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.