Switch from @messageformat/core to intl-messageformat#547
Open
andersk wants to merge 1 commit intomashpie:masterfrom
Open
Switch from @messageformat/core to intl-messageformat#547andersk wants to merge 1 commit intomashpie:masterfrom
@messageformat/core to intl-messageformat#547andersk wants to merge 1 commit intomashpie:masterfrom
Conversation
andersk
force-pushed
the
intl-messageformat
branch
from
6c505ab to
d1cc11c
Compare
In a website with a Content-Security-Policy that does not allow unsafe-eval, the @messageformat/core compiler crashes with EvalError, and upstream has no plans to address that; they recommend pre-compiling all functions using a build step, or switching to intl-messageformat. Fixes mashpie#545. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
force-pushed
the
intl-messageformat
branch
from
d1cc11c to
079fd7a
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #547 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 2 2
Lines 548 548
=======================================
Hits 538 538
Misses 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a website with a
Content-Security-Policythat does not allowunsafe-eval, the@messageformat/corecompiler crashes withEvalError, and upstream has no plans to address that; they recommend pre-compiling all functions using a build step, or switching tointl-messageformat.__mfcrashes withEvalErrorunder a restrictive Content-Security-Policy #545.