Fix: multiple locale handling issues and add JSON validation (#387, #344, #501, #522, #378)#543
Open
Kofacts wants to merge 1 commit intomashpie:masterfrom
Open
Conversation
…leteness, and add JSON validation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Owner
|
Thanks a lot for this PR! Clean code, perfect tests :) and a good improvement. One question remains: Didn't you also want to call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses several critical locale handling issues and adds comprehensive JSON validation.
undefinedwhen provided locale isundefinedornull#501).All changes are fully tested with 49 new comprehensive test cases covering edge cases and ensuring no regressions.