Open
Conversation
Mattermost::Request::get() with auto paging mode and handle exception on error reading.
maruTA-bis5
requested changes
Jan 26, 2019
Owner
maruTA-bis5
left a comment
maruTA-bis5
left a comment
There was a problem hiding this comment.
Sorry for late response.
If your application like Mattermost webapp, and you selected long-living channel such as "town-square", this modify causes a lot of requests happen because that channel has too many messages. (Request#get is called by many api internally.)
So you should make "Auto paging mode" optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mattermost::Request::get() with auto paging mode and handle exception on error reading.