Skip to content

Conversation

@martynia
Copy link
Owner

@martynia martynia commented Nov 5, 2020

This PR contains a draft of a Rucio File Catalog plugin which uses REST interface provided by the Rucio server. The Rucio client python bindings only contain operations required by RucioFileCatalogClient plugin to perform synchronous upload/download and listing operations. The clients:

  • use X509 authentication only
  • the configuration is entirely stored in the Dirac CS (a proxy location, CA location, VO, Dirac username/Rucio account and Rucio hosts URLs)

A need of a Rucio config file and environment variables which are commonly used to configure Rucio client is eliminated.

@cserf
Copy link

cserf commented Nov 6, 2020

Just one first comment before reading the code in more details. The file into Resources/Catalog/RucioRESTClientApi are largely a copy and paste of the files into https://github.com/rucio/rucio/tree/master/lib/rucio/client . This is allowed by the Apache license I think (@bari12 should confirm), but at least the copyright cannot be dropped.

@bari12
Copy link

bari12 commented Nov 9, 2020

Hi,
Correct, it is allowed to copy&modify the code under Apache2.0 license, but the license/copyright notice should be kept.
It would be good though (Although not strictly required) to link back where the code came from and maybe keep the list of original authors.
Cheers, Martin

@martynia
Copy link
Owner Author

I added the licence, lists of original authors and a link to the original code. Is it how you wanted this to be @bari12 ?

@martynia martynia force-pushed the rel-v7r1_janusz_rucio_REST_dev branch from 926e9d1 to 3cc7364 Compare November 20, 2020 16:51
@bari12
Copy link

bari12 commented Nov 20, 2020

Perfect 👍 , thanks a lot @martynia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants