Improvement plan phases 4–5: UX escalation, a11y, responsive layout, store fixes, docs#13
Merged
Merged
Conversation
…, docs - Rewrite level 49 variance with AVG(x^2) - AVG(x)^2 identity (no more correlated subqueries); normalize seed-scaffold whitespace - Split levels.ts into per-epoch modules under src/data/levels/ - Fix three store bugs found while writing its tests: XP could be farmed by replaying completed levels, completing the final level advanced currentLevel past MAX_LEVEL, and goToPreviousLevel never consumed history (back button bounced between two levels) - Escalating disclosure: after 3 failed attempts reveal the expected result's shape (columns + row count), never its values - A11y: dialog roles/aria-modal/focus and Escape handling on the level-up modal and level navigator, aria-labels on icon buttons, aria-pressed on the schema/data tabs - Responsive: editor and schema panels stack full-width below lg - Docs: MIT LICENSE, CONTRIBUTING.md with level-authoring guide, README links, plan status update https://claude.ai/code/session_01RQVRtRAigoNCzJc37A5Ses
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the remaining items from
IMPROVEMENT_PLAN.md(follow-up to #12): the rest of Phase 1/3, Phase 4 UX & accessibility, and Pillar 5 docs.Level content
AVG(x²) − AVG(x)²identity (the same pattern level 63 teaches) instead of correlated subqueries that re-derived the mean twice.levels.tssplit into per-epoch modules undersrc/data/levels/(foundational/intermediate/advanced/expert + index) — all imports unchanged via the directory index.Store fixes (found by the new tests)
Writing the store tests surfaced three real bugs, all fixed:
currentLevelto 64, which has no data; now clamped toMAX_LEVEL.goToPreviousLevelnever persisted the popped history, so repeated presses bounced between the last two levels instead of walking back.UX & accessibility (Phase 4)
role="dialog"/aria-modal/labelled headings, initial focus, and Escape-to-close on both the level-up modal and the level navigator drawer;aria-labels on icon-only buttons;aria-pressedon the schema/data tabs;aria-currenton the active level tile.lgbreakpoint instead of overflowing at fixed widths.Docs (Pillar 5)
ORDER BY/orderMatters, seed-scaffold conventions, and the test gates.Verification
npm run lint— cleannpm run typecheck— cleannpm test— 278/278 (8 new store tests)npm run build— succeedshttps://claude.ai/code/session_01RQVRtRAigoNCzJc37A5Ses
Generated by Claude Code