refactor(skill): document functional style companion boundary#73
Open
martinfrancois wants to merge 1 commit into
Open
refactor(skill): document functional style companion boundary#73martinfrancois wants to merge 1 commit into
martinfrancois wants to merge 1 commit into
Conversation
Document that java-optionals owns Optional behavior while java-functional-style owns generic lambda, identity-function, no-op functional stage, and callback readability guidance. The runtime skill and eval criteria are unchanged, so existing Optional behavior remains the comparison baseline for any later composition gate. Co-Authored-By: marvinbuff <marvinbuff@hotmail.com> Co-Authored-By: PReimers <preimers@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
java-optionalsneeded a clear ownership boundary with the new cross-cutting Java functional-style package.java-functional-style.Change Type
Linked Issue
User-Visible Behavior
Contributors and users can now see that
java-optionalsowns Optional semantics whilemartinfrancois/java-functional-styleowns general lambda/callback readability, identity functions, no-op functional stages, supplier/callback style, and side-effect boundaries.Bug Fix Details
Ownership Boundary
java-optionalsowns Optional semantics: absence and fallback behavior, Optional API choice, fallback laziness as Optional semantics, checked IO/parser/prompt boundaries, Java-version compatibility, and present/absent/exception contract preservation.java-functional-styleowns general Java lambda and functional-interface style: method references, identity functions, no-op functional stages, callback extraction, supplier laziness as general callback style, and callback side-effect guidance.Validation
Checks most contributors can run:
python3 scripts/validate_skill.py skills/java-optionals-> passedpython3 scripts/validate_eval_criteria.py evals evals-reference evals-regression-> passed,Validated 52 scenario(s): 4 natural, 48 explicit.python3 -m py_compile scripts/*.py-> passedbash -n scripts/*.sh-> passedpython3 scripts/validate_json_files.py-> passedpython3 scripts/validate_openai_agent_yaml.py-> passedtessl plugin lint .-> passedTessl-authenticated checks:
bash scripts/check_publish_dry_run.sh .-> not run; no publish-related changetessl plugin publish --dry-run --bump patch .-> not run; no publish-related changetessl skill review --threshold 100 skills/java-optionals/SKILL.md/ equivalent quality review -> 100, run019f0f80-6ab4-775d-a973-0ab001271473Details:
Human Verification
Review Checklist
docs/agents/workflow.md, or any Tessl blocker is documented.AI Assistance (if used)
AI prompts / session logs (optional)