add unknown optional keywords to parse and use_args#506
Closed
zenglanmu wants to merge 2 commits intomarshmallow-code:devfrom
zenglanmu:dev
Closed
add unknown optional keywords to parse and use_args#506zenglanmu wants to merge 2 commits intomarshmallow-code:devfrom zenglanmu:dev
zenglanmu wants to merge 2 commits intomarshmallow-code:devfrom
zenglanmu:dev
Conversation
Collaborator
|
As mentioned in #514, I think we prefer an approach in which dict schemas and regular schemas are treated the same. In light of that, and given that I'm trying to get 7.0 ready in the next few weeks or months, I'm going to close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow user to set the unknown field is important in some cases. For example, the query also have an additional per_page args which handled by other library. Current webargs with version 6.0 behavior ould raise an validation error, which causes broken changes since verision 5. Maybe it is better to set unknown=EXCLUDE as default behavior or at least gives the user the ability to set it.